toby/somebar
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix possible OOB access for clicking tags

Browse source 
specify the signed type for indexing tags as intended
for `tag >= 0` check.

Signed-off-by: mortezadadgar <mortezadadgar97@gmail.com>
This commit is contained in:
mortezadadgar 2023-08-01 09:45:53 +03:30 committed by Raphael Robatsch
parent b069830640
commit e1f8c63064
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/bar.cpp
View file

@ -181,7 +181,7 @@ void Bar::click(Monitor* mon, int x, int, int btn)
control = ClkWinTitle; control = ClkWinTitle;
} else if (x > _layoutCmp.x) { } else if (x > _layoutCmp.x) {
control = ClkLayoutSymbol; control = ClkLayoutSymbol;
} else for (auto tag = _tags.size()-1; tag >= 0; tag--) { } else for (int tag = _tags.size()-1; tag >= 0; tag--) {
if (x > _tags[tag].component.x) { if (x > _tags[tag].component.x) {
control = ClkTagBar; control = ClkTagBar;
arg.ui = 1<<tag; arg.ui = 1<<tag;