From 9b9992a015a7e5a8bff3afc9b9253fb00ec7ff40 Mon Sep 17 00:00:00 2001
From: Tobias Berger <tobi.berger13@gmail.com>
Date: Tue, 5 Oct 2021 12:54:19 +0200
Subject: [PATCH] Make normal links in header more generic

---
 src/components/Header.svelte | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/components/Header.svelte b/src/components/Header.svelte
index 0e96fb9..ad8de7c 100644
--- a/src/components/Header.svelte
+++ b/src/components/Header.svelte
@@ -35,10 +35,7 @@
     donate() {
       console.log("donate");
     },
-    discord() {
-      // No-Op
-      throw new Error("This function shouldn't have been called.");
-    },
+    discord: discordLink,
     notice() {
       console.log("notice");
     },
@@ -52,17 +49,23 @@
 <header id="header">
   <ul id="main-header-buttons">
     {#each Object.entries(mainHeaderButtons) as [name, onClick]}
-      <li><a on:click={onClick} href={"javascript:;"}>{name}</a></li>
+      <li>
+        {#if typeof onClick === "function"}
+          <a on:click={onClick} href={"javascript:;"}>{name}</a>
+        {:else if typeof onClick === "string"}
+          <a target="_blank" rel="noreferrer noopener" href={onClick}>{name}</a>
+        {/if}
+      </li>
     {/each}
   </ul>
   <span>{title}</span>
   <ul id="other-header-buttons">
     {#each Object.entries(otherHeaderButtons) as [name, onClick]}
       <li>
-        {#if name === "discord"}
-          <a href={discordLink} rel="noopener" target="_blank">{name}</a>
-        {:else}
+        {#if typeof onClick === "function"}
           <a on:click={onClick} href={"javascript:;"}>{name}</a>
+        {:else if typeof onClick === "string"}
+          <a target="_blank" rel="noreferrer noopener" href={onClick}>{name}</a>
         {/if}
       </li>
     {/each}